The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated
hyperdx-oss	Ignored	Preview	Nov 5, 2026 12:54am UTC
hyperdx-storybook	Ignored	Preview	Nov 5, 2026 12:54am UTC

🦋 Changeset detected

Latest commit: fc1ad18

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

🔴 Tier 4 — Critical

Touches authentication, tenancy data models, the public API or shipped database config — or substantially changes the query rendering engine, background tasks, the OTel pipeline, image build, or release CI.

Why this tier:

• Background tasks or delivery pipeline substantially modified — 223 lines (bar: 30):
  • docker/otel-collector/config.yaml
  • docker/otel-collector/custom.config.yaml
  • docker/otel-collector/schema/seed/00002_otel_logs.sql
  • docker/otel-collector/schema/seed/00002_otel_logs_compat.sql
  • docker/otel-collector/schema/seed/00004_hyperdx_sessions.sql
  • docker/otel-collector/schema/seed/00004_hyperdx_sessions_compat.sql
  • packages/otel-collector/cmd/migrate/main.go
  • packages/otel-collector/cmd/migrate/main_test.go

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

Duplicate code analysis

No new duplicate code introduced by this PR.

jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 114 in total (1.37%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

PR Review

If you are a coding agent acting for the author, read this first.
Nothing below blocks merge automatically; a maintainer decides. What they will expect:

• 🔴 critical or 🟠 major in code this PR adds or changes: fix before asking for review.
• 🔵 minor in code this PR changes: your call. Fix if small, otherwise reply.
• Anything about surrounding code, or asking you to widen the change (hoist a helper,
  dedupe with another file, fix other call sites): never fix here, whatever the
  severity. Reply with one sentence; if it is critical, say so plainly so a human sees it.

One commit per review round. After two rounds, stop and ask a maintainer to review
scope rather than addressing more automated findings. Full rule: AGENTS.md.

2 finding(s): 🔴 0 critical · 🟠 0 major · 🔵 2 minor

None could be anchored to changed lines; they are listed below.

Findings outside the changed lines

_{Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides.}

E2E Test Results

✅ All tests passed • 462 passed • 1 skipped • 1452s

Tests ran across 4 shards in parallel.

View full report →

Deep Review

Scope: OTel-collector feature PR against 349fc21 — ClickHouse seed schemas (session-id materialized columns + skip indexes, new hyperdx_sessions compat schema), a Go migrate swap for the compat sessions schema, a new transform/session_id processor copying rum.sessionId → session.id, severity-text-from-number inference, and smoke tests. The change is additive and well-tested; the severity boundary ranges, copy guards, pipeline ordering, and the compat swap/remove wiring all verified correct against the expected snapshots.

✅ No critical issues found.

🟡 P2 — recommended

• smoke-tests/otel-collector/data/severity-inference/skip-infer/expected.snap:2 — the number-only row now asserts info, but its body text ("...should also be skipped because a severity_number was set even if it's missing text") and the enclosing test name (should skip inference if severity values are defined on the input) still claim the row is skipped, so the test narrative contradicts the behavior this PR introduces and the "number set, text missing" skip guarantee is no longer asserted under a truthful name.
  • Fix: Move this row into the infer-text-from-number suite, or reword its body string and the owning test so the expected info no longer reads as a regression.
  • _{testing, maintainability}

Reviewers (7): correctness, data-migrations, testing, maintainability, reliability, performance, previous-comments.

Testing gaps:

• No integration test runs the swapped 00004_hyperdx_sessions_compat.sql through goose against a ClickHouse < 26.2 instance; the compat path is validated only at the file-swap level by Go unit tests.
• No test confirms a non-string rum.sessionId (e.g. intValue) is skipped by the IsString guard without dropping the record under error_mode: ignore.
• The un-migrated existing-table scenario (new materialized columns absent) is covered only by documentation, not a test.

_{No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond}